Skip to content

[Checkout] Enhance redirect handling for different payment types #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[Checkout] Enhance redirect handling for different payment types #6959

merged 1 commit into from
May 7, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 6, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR refactors the handling of different result.type cases in the CheckoutEmbed.client.tsx file. It replaces conditional checks with a switch statement to better manage the URL parameters based on the type of transaction.

Detailed summary

  • Replaced multiple if statements with a switch statement for result.type.
  • Added a case for crypto to set status and optionally txHash.
  • Added a case for fiat to set status and optionally intentId.
  • Retained the case for transaction to set txHash.
  • Ensured url is opened after processing all cases.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 11:43am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 6, 2025 11:43am
login ⬜️ Skipped (Inspect) May 6, 2025 11:43am
thirdweb_playground ⬜️ Skipped (Inspect) May 6, 2025 11:43am
wallet-ui ⬜️ Skipped (Inspect) May 6, 2025 11:43am

@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 11:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 11:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 11:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 11:37 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: bf69114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review May 6, 2025 11:37
@joaquim-verges joaquim-verges requested review from a team as code owners May 6, 2025 11:37
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (9d40b13) to head (bf69114).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6959   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57342           
  Branches     3967     3967           
=======================================
  Hits        31558    31558           
  Misses      25687    25687           
  Partials       97       97
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 185 ms (+183.13% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 311 ms (+84.61% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 81 ms (+1484.37% 🔺) 194 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 39 ms (+1727.9% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 82 ms (+666.25% 🔺) 472 ms

@joaquim-verges joaquim-verges merged commit 490497c into main May 7, 2025
26 checks passed
@joaquim-verges joaquim-verges deleted the _Checkout_Enhance_redirect_handling_for_different_payment_types branch May 7, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges